Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: Source/devtools/front_end/sdk/OverridesSupport.js

Issue 342433002: DevTools: cleanup Network.emulateNetworkConditions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/elements/OverridesView.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/OverridesSupport.js
diff --git a/Source/devtools/front_end/sdk/OverridesSupport.js b/Source/devtools/front_end/sdk/OverridesSupport.js
index e0616cc560eafe42d10be392e9ce61a09a722ff9..7938c7692950abfb20067fbf01f85aaa34469af0 100644
--- a/Source/devtools/front_end/sdk/OverridesSupport.js
+++ b/Source/devtools/front_end/sdk/OverridesSupport.js
@@ -270,22 +270,6 @@ WebInspector.OverridesSupport.deviceScaleFactorValidator = function(value)
return WebInspector.UIString("Value must be non-negative float");
}
-/**
- * @param {string} value
- * @return {string}
- */
-WebInspector.OverridesSupport.networkDomainsValidator = function(value)
-{
- function test(s)
- {
- return /^[\w\-]+(\.[\w\-]+)*$/.test(s.trim());
- }
-
- if (!value.trim())
- return "";
- return value.split(",").every(test) ? "" : WebInspector.UIString("Value must be a comma-separated list of domains");
-}
-
// Second element is user agent value.
// Third element lists device metrics separated by 'x':
// - screen width,
@@ -579,7 +563,6 @@ WebInspector.OverridesSupport.prototype = {
if (WebInspector.experimentsSettings.networkConditions.isEnabled()) {
this.settings.emulationEnabled.addChangeListener(this._networkConditionsChanged, this);
- this.settings.networkConditionsDomains.addChangeListener(this._networkConditionsChanged, this);
this.settings.networkConditionsThroughput.addChangeListener(this._networkConditionsChanged, this);
}
@@ -777,13 +760,11 @@ WebInspector.OverridesSupport.prototype = {
_networkConditionsChanged: function()
{
if (!this.settings.emulationEnabled.get() || !this.networkThroughputIsLimited()) {
- NetworkAgent.emulateNetworkConditions([], 0, false, 0, 0, 0);
+ NetworkAgent.emulateNetworkConditions(false, 0, 0, 0);
} else {
- var domainsString = this.settings.networkConditionsDomains.get().trim();
- var domains = domainsString ? domainsString.split(",").map(function (s) { return s.trim(); }) : [];
var throughput = this.settings.networkConditionsThroughput.get();
var offline = !throughput;
- NetworkAgent.emulateNetworkConditions(domains, throughput, offline, 0, throughput, throughput);
+ NetworkAgent.emulateNetworkConditions(offline, 0, throughput, throughput);
}
this.maybeHasActiveOverridesChanged();
},
@@ -896,7 +877,6 @@ WebInspector.OverridesSupport.prototype = {
this.settings.overrideCSSMedia = WebInspector.settings.createSetting("overrideCSSMedia", false);
this.settings.emulatedCSSMedia = WebInspector.settings.createSetting("emulatedCSSMedia", "print");
- this.settings.networkConditionsDomains = WebInspector.settings.createSetting("networkConditionsDomains", "");
this.settings.networkConditionsThroughput = WebInspector.settings.createSetting("networkConditionsThroughput", WebInspector.OverridesSupport._networkThroughputUnlimitedValue);
this.maybeHasActiveOverridesChanged();
« no previous file with comments | « Source/devtools/front_end/elements/OverridesView.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698