Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 342091: Add a CHECK when an object tries to remove itself as an observer from Notific... (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a CHECK when an object tries to remove itself as an observer from NotificationService but no matching entry is found. This is most likely an object being deleted on the wrong thread, and it'll lead to a crash later. BUG=25354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/common/notification_service.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
11 years, 1 month ago (2009-11-03 04:05:51 UTC) #1
darin (slow to review)
OK! crossing my fingers there isn't too much benign fallout.
11 years, 1 month ago (2009-11-03 04:16:38 UTC) #2
jam
11 years, 1 month ago (2009-11-03 04:30:18 UTC) #3
I'm crossing my fingers there are :)  These would be trivial to fix when we
find them!

On Mon, Nov 2, 2009 at 8:16 PM, <darin@chromium.org> wrote:

> OK!  crossing my fingers there isn't too much benign fallout.
>
>
> http://codereview.chromium.org/342091
>

Powered by Google App Engine
This is Rietveld 408576698