Chromium Code Reviews
Help | Chromium Project | Sign in
(21)

Issue 342091: Add a CHECK when an object tries to remove itself as an observer from Notific... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by jam
Modified:
2 years, 10 months ago
Reviewers:
darin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a CHECK when an object tries to remove itself as an observer from NotificationService but no matching entry is found. This is most likely an object being deleted on the wrong thread, and it'll lead to a crash later.

BUG=25354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Lint Patch
M chrome/common/notification_service.cc View 1 chunk +8 lines, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
jam
4 years, 5 months ago #1
darin
OK! crossing my fingers there isn't too much benign fallout.
4 years, 5 months ago #2
jam
4 years, 5 months ago #3
I'm crossing my fingers there are :)  These would be trivial to fix when we
find them!

On Mon, Nov 2, 2009 at 8:16 PM, <darin@chromium.org> wrote:

> OK!  crossing my fingers there isn't too much benign fallout.
>
>
> http://codereview.chromium.org/342091
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6