Use ChromeThread::DeleteOnIOThread in a few places where an object must be de...

chrome/browser/renderer_host/audio_renderer_host.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // TODO(hclam): Several changes need to be made to this code:
 // 1. We should host AudioRendererHost on a dedicated audio thread. Doing
 //    so we don't have to worry about blocking method calls such as
 //    play / stop an audio stream.
 // 2. Move locked data structures into a separate structure that sanity
 //    checks access by different threads that use it.
 //
 // SEMANTICS OF |state_|
 // Note that |state_| of IPCAudioSource is accessed on two thread. Namely
 // the IO thread and the audio thread. IO thread is the thread on which
 // IPAudioSource::Play(), IPCAudioSource::Pause() are called. Audio thread
 // is a thread operated by the audio hardware for requesting data.
 // It is important that |state_| is only written on the IO thread because
 // reading of such state in Play() and Pause() is not protected. However,
 // since OnMoreData() is called on the audio thread and reads |state_|
 // variable. Writing to this variable needs to be protected in Play()
 // and Pause().
 
 #include "base/histogram.h"
 #include "base/lock.h"
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "base/waitable_event.h"
-#include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/renderer_host/audio_renderer_host.h"
 #include "chrome/common/render_messages.h"
 #include "ipc/ipc_logging.h"
 
 namespace {
 
 // This constant governs the hardware audio buffer size, this value should be
 // choosen carefully and is platform specific.
 const int kSamplesPerHardwarePacket = 8192;
 
@@ skipping 289 matching lines @@
   SubmitPacketRequest(NULL);
 }
 
 //-----------------------------------------------------------------------------
 // AudioRendererHost implementations.
 
 AudioRendererHost::AudioRendererHost()
     : process_id_(0),
       process_handle_(0),
       ipc_sender_(NULL) {
-  // Make sure we perform actual initialization operations in the thread where
-  // this object should live.
-  ChromeThread::PostTask(
-      ChromeThread::IO, FROM_HERE,
-      NewRunnableMethod(this, &AudioRendererHost::OnInitialized));
+  // Increase the ref count of this object so it is active until we do
+  // Release().
+  AddRef();
 }
 
 AudioRendererHost::~AudioRendererHost() {
+  DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
   DCHECK(sources_.empty());
 }
 
 void AudioRendererHost::Destroy() {
   // Post a message to the thread where this object should live and do the
   // actual operations there.
   ChromeThread::PostTask(
       ChromeThread::IO, FROM_HERE,
       NewRunnableMethod(this, &AudioRendererHost::OnDestroyed));
 }
@@ skipping 135 matching lines @@
                                             int stream_id, size_t packet_size) {
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
   IPCAudioSource* source = Lookup(msg.routing_id(), stream_id);
   if (source) {
     source->NotifyPacketReady(packet_size);
   } else {
     SendErrorMessage(msg.routing_id(), stream_id);
   }
 }
 
-void AudioRendererHost::OnInitialized() {
-  DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
-  // Increase the ref count of this object so it is active until we do
-  // Release().
-  AddRef();
-}
-
 void AudioRendererHost::OnDestroyed() {
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
   ipc_sender_ = NULL;
   process_handle_ = 0;
   process_id_ = 0;
   DestroyAllSources();
   // Decrease the reference to this object, which may lead to self-destruction.
   Release();
 }
 
@@ skipping 54 matching lines @@
 
 void AudioRendererHost::DestroySource(IPCAudioSource* source) {
   if (ChromeThread::CurrentlyOn(ChromeThread::IO)) {
     OnDestroySource(source);
   } else {
     ChromeThread::PostTask(
         ChromeThread::IO, FROM_HERE,
         NewRunnableMethod(this, &AudioRendererHost::OnDestroySource, source));
   }
 }