Issue 342090: Use ChromeThread::DeleteOnIOThread in a few places where an object must be de...

Issue 342090: Use ChromeThread::DeleteOnIOThread in a few places where an object must be de... (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use ChromeThread::DeleteOnIOThread in a few places where an object must be deleted on a certain thread. BUG=25354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30882

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -63 lines)			Patch
M	chrome/browser/renderer_host/audio_renderer_host.h	View	1 2	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/audio_renderer_host.cc	View	1 2	3 chunks	+4 lines, -13 lines	0 comments	Download
M	chrome/browser/renderer_host/buffered_resource_handler.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/buffered_resource_handler.cc	View	1 2	3 chunks	+13 lines, -23 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_handler.h	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/spellchecker.h	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/spellchecker.cc	View	1 2	5 chunks	+3 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM if you fix the first comment http://codereview.chromium.org/342090/diff/1/4 File chrome/browser/renderer_host/audio_renderer_host.h (right): http://codereview.chromium.org/342090/diff/1/4#newcode95 Line 95: // ...

11 years, 1 month ago (2009-11-03 06:18:26 UTC) #2

jam

11 years, 1 month ago (2009-11-03 21:06:20 UTC) #3

http://codereview.chromium.org/342090/diff/1/4
File chrome/browser/renderer_host/audio_renderer_host.h (right):

http://codereview.chromium.org/342090/diff/1/4#newcode95
Line 95: // Destruction can happen on either UI thread or IO thread, but at
destruction
On 2009/11/03 06:18:26, Evan Martin wrote:
> This comment is now wrong, isn't it?  It always happens on IO thread?

You're right.  I've updated the comment, and also updated the cc file to remove
some complexity that's not needed anymore.

http://codereview.chromium.org/342090/diff/1/7
File chrome/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/342090/diff/1/7#newcode483
Line 483: }
On 2009/11/03 06:18:26, Evan Martin wrote:
> curlies not necessary here

Done.

Expand Messages | Collapse Messages