Chromium Code Reviews
Help | Chromium Project | Sign in
(692)

Issue 342090: Use ChromeThread::DeleteOnIOThread in a few places where an object must be de... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by jam
Modified:
2 years, 10 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin, jam, ben+cc_chromium.org
Visibility:
Public.

Description

Use ChromeThread::DeleteOnIOThread in a few places where an object must be deleted on a certain thread.

BUG=25354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30882

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -63 lines) Lint Patch
M chrome/browser/renderer_host/audio_renderer_host.h View 1 2 3 chunks +5 lines, -6 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/audio_renderer_host.cc View 1 2 3 chunks +4 lines, -13 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/buffered_resource_handler.h View 1 2 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 2 3 chunks +13 lines, -23 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/resource_handler.h View 1 2 2 chunks +4 lines, -1 line 0 comments 0 errors Download
M chrome/browser/spellchecker.h View 1 2 2 chunks +5 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/spellchecker.cc View 1 2 5 chunks +3 lines, -15 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
jam
4 years, 5 months ago #1
Evan Martin
LGTM if you fix the first comment http://codereview.chromium.org/342090/diff/1/4 File chrome/browser/renderer_host/audio_renderer_host.h (right): http://codereview.chromium.org/342090/diff/1/4#newcode95 Line 95: // ...
4 years, 5 months ago #2
jam
4 years, 5 months ago #3
http://codereview.chromium.org/342090/diff/1/4
File chrome/browser/renderer_host/audio_renderer_host.h (right):

http://codereview.chromium.org/342090/diff/1/4#newcode95
Line 95: // Destruction can happen on either UI thread or IO thread, but at
destruction
On 2009/11/03 06:18:26, Evan Martin wrote:
> This comment is now wrong, isn't it?  It always happens on IO thread?

You're right.  I've updated the comment, and also updated the cc file to remove
some complexity that's not needed anymore.

http://codereview.chromium.org/342090/diff/1/7
File chrome/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/342090/diff/1/7#newcode483
Line 483: }
On 2009/11/03 06:18:26, Evan Martin wrote:
> curlies not necessary here

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6