chrome/browser/extensions/unpacked_installer.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synchronized page loading, support multiple load errors Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/unpacked_installer.h ('k') | chrome/browser/resources/extensions/extension_load_error.html » ('j') | chrome/browser/resources/extensions/extension_load_error.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index cb7966f8908b27b491430611cfdbff67953ee48d..83db9d603c0c8553f6a7bd4cadfb31b066158b3d 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -296,8 +296,6 @@ void UnpackedInstaller::LoadWithFileAccess(int flags) {

void UnpackedInstaller::ReportExtensionLoadError(const std::string &error) {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- if (!on_failure_callback_.is_null())

- on_failure_callback_.Run(extension_path_, error);

if (service_weak_.get()) {

ExtensionErrorReporter::GetInstance()->ReportLoadError(

@@ -308,6 +306,7 @@ void UnpackedInstaller::ReportExtensionLoadError(const std::string &error) {

}

Devlin 2014/06/27 22:31:08 nit: remove extraneous newline.

gpdavis 2014/06/28 02:31:17 Done.

void UnpackedInstaller::ConfirmInstall() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

base::string16 error = installer_.CheckManagementPolicy();