Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 869a8dd99b53acad8468184a7f086e9fbae5cf6d..a36b146bfeb1a029b7eab0f76951b4c483a91945 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -682,7 +682,10 @@ void ExtensionService::ReloadExtension(
     // We should always be able to remember the extension's path. If it's not in
     // the map, someone failed to update |unloaded_extension_paths_|.
     CHECK(!path.empty());
-    extensions::UnpackedInstaller::Create(this)->Load(path);
+    scoped_refptr<extensions::UnpackedInstaller> unpacked_installer =
+        extensions::UnpackedInstaller::Create(this);
+    unpacked_installer->set_be_noisy_on_failure(false);

[Devlin, 2014/06/27 22:31:08]

Won't this still have problems with things other than chrome:extensions
reloading extensions?

[gpdavis, 2014/06/27 23:42:54]

Oops, you're absolutely right.  There must be some way to make this
determination.  The problem is that this UnpackedInstaller gets created and used
right here, so this is the only opportunity to tell it not to be noisy.  Perhaps
we could add an extra boolean argument to ReloadExtension?  That doesn't seem
entirely unreasonable of a thing to add to a ReloadExtension call.  What do you
think?

+    unpacked_installer->Load(path);
   }
   // When reloading is done, mark this extension as done reloading.
   SetBeingReloaded(extension_id, false);