Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prettified failure path Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index e1a0ebd9bfa8ae5b7552168643b67fe4a8513204..95bd11b59a60c1acf8058eb8a240f92079754066 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -255,8 +255,12 @@ class ExtensionService
// Reloads the specified extension, sending the onLaunched() event to it if it
// currently has any window showing.
+ // Allows noisy failures.
void ReloadExtension(const std::string& extension_id);
+ // Suppresses noisy failures.
+ void ReloadExtensionWithQuietFailure(const std::string& extension_id);
+
// Uninstalls the specified extension. Callers should only call this method
// with extensions that exist. |reason| lets the caller specify why the
// extension is uninstalled.
@@ -449,6 +453,11 @@ class ExtensionService
private:
+ // Reloads the specified extension, sending the onLaunched() event to it if it
+ // currently has any window showing. |be_noisy| determines whether noisy
+ // failures are allowed for unpacked extension installs.
+ void ReloadExtensionImpl(const std::string& extension_id, bool be_noisy);
+
// content::NotificationObserver implementation:
virtual void Observe(int type,
const content::NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698