Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/extensions/extension_error_reporter.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prettified failure path Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_error_reporter.cc
diff --git a/chrome/browser/extensions/extension_error_reporter.cc b/chrome/browser/extensions/extension_error_reporter.cc
index 837402bea19937013fae60b73f8da0d825aefec4..303a339eb4074eea39605b5eb9115137a45ed30d 100644
--- a/chrome/browser/extensions/extension_error_reporter.cc
+++ b/chrome/browser/extensions/extension_error_reporter.cc
@@ -55,6 +55,9 @@ void ExtensionErrorReporter::ReportLoadError(
path_str.c_str(),
error.c_str()));
ReportError(message, be_noisy);
+ FOR_EACH_OBSERVER(Observer,
+ observers_,
+ OnLoadFailure(extension_path, error));
}
void ExtensionErrorReporter::ReportError(const base::string16& message,
@@ -86,3 +89,11 @@ const std::vector<base::string16>* ExtensionErrorReporter::GetErrors() {
void ExtensionErrorReporter::ClearErrors() {
errors_.clear();
}
+
+void ExtensionErrorReporter::AddObserver(Observer* observer) {
+ observers_.AddObserver(observer);
+}
+
+void ExtensionErrorReporter::RemoveObserver(Observer* observer) {
+ observers_.RemoveObserver(observer);
+}

Powered by Google App Engine
This is Rietveld 408576698