Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/extensions/unpacked_installer.cc

Index: chrome/browser/extensions/unpacked_installer.cc
diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc
index cb7966f8908b27b491430611cfdbff67953ee48d..96437570019ca481b620e1e4d7a033de3b8ab457 100644
--- a/chrome/browser/extensions/unpacked_installer.cc
+++ b/chrome/browser/extensions/unpacked_installer.cc
@@ -114,7 +114,7 @@ UnpackedInstaller::UnpackedInstaller(ExtensionService* extension_service)
     : service_weak_(extension_service->AsWeakPtr()),
       prompt_for_plugins_(true),
       require_modern_manifest_version_(true),
-      be_noisy_on_failure_(true),
+      be_noisy_on_failure_(false),

[Devlin, 2014/06/24 22:21:12]

Won't this potentially make other things which should be noisy, not?  E.g. if we
load an extension from the Chrome Apps & Extensions Developer Tool?

[gpdavis, 2014/06/25 00:21:01]

Yes, that is true.  But do we ever want it to be noisy, considering the goal
here is to have the UI show up whenever there is a failure?  Under what
circumstances exactly do we want this to be true or false?

[Devlin, 2014/06/25 19:49:36]

We want this to be noisy whenever:
a) It is current noisy, and
b) We won't show the new UI.

A little searching around the code base will tell you exactly when that is, but
the main one I can think of is the one I mentioned before - when we load an
extension via Chrome Apps and Extensions Developer Tool.

       installer_(extension_service->profile()) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }