Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/extensions/unpacked_installer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/unpacked_installer.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ skipping 96 matching lines @@
     ExtensionService* extension_service) {
   DCHECK(extension_service);
   return scoped_refptr<UnpackedInstaller>(
       new UnpackedInstaller(extension_service));
 }
 
 UnpackedInstaller::UnpackedInstaller(ExtensionService* extension_service)
     : service_weak_(extension_service->AsWeakPtr()),
       prompt_for_plugins_(true),
       require_modern_manifest_version_(true),
-      be_noisy_on_failure_(true),
+      be_noisy_on_failure_(false),

[Devlin, 2014/06/24 22:21:12]

Won't this potentially make other things which should be noisy, not?  E.g. if we
load an extension from the Chrome Apps & Extensions Developer Tool?

[gpdavis, 2014/06/25 00:21:01]

Yes, that is true.  But do we ever want it to be noisy, considering the goal
here is to have the UI show up whenever there is a failure?  Under what
circumstances exactly do we want this to be true or false?

[Devlin, 2014/06/25 19:49:36]

We want this to be noisy whenever:
a) It is current noisy, and
b) We won't show the new UI.

A little searching around the code base will tell you exactly when that is, but
the main one I can think of is the one I mentioned before - when we load an
extension via Chrome Apps and Extensions Developer Tool.

       installer_(extension_service->profile()) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
 UnpackedInstaller::~UnpackedInstaller() {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI) ||
         BrowserThread::CurrentlyOn(BrowserThread::FILE));
 }
 
 void UnpackedInstaller::Load(const base::FilePath& path_in) {
@@ skipping 161 matching lines @@
   }
 
   BrowserThread::PostTask(
       BrowserThread::UI,
       FROM_HERE,
       base::Bind(&UnpackedInstaller::ShowInstallPrompt, this));
 }
 
 void UnpackedInstaller::ReportExtensionLoadError(const std::string &error) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!on_failure_callback_.is_null())

[Devlin, 2014/06/24 22:21:12]

I could be wrong, but I think the only class that ever set this was the
LoaderHandler.  If so, you can remove it.

     on_failure_callback_.Run(extension_path_, error);
 
   if (service_weak_.get()) {
     ExtensionErrorReporter::GetInstance()->ReportLoadError(
         extension_path_,
         error,
         service_weak_->profile(),
         be_noisy_on_failure_);
   }
 }
 
 void UnpackedInstaller::ConfirmInstall() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   base::string16 error = installer_.CheckManagementPolicy();
   if (!error.empty()) {
     ReportExtensionLoadError(base::UTF16ToUTF8(error));
     return;
   }
 
   PermissionsUpdater perms_updater(service_weak_->profile());
   perms_updater.GrantActivePermissions(installer_.extension().get());
 
   service_weak_->OnExtensionInstalled(installer_.extension().get(),
                                       syncer::StringOrdinal(),
                                       kInstallFlagInstallImmediately);
 }
 
 }  // namespace extensions