apps/app_load_service.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/app_load_service.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved path handling back to C++ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/app_load_service.cc

diff --git a/apps/app_load_service.cc b/apps/app_load_service.cc

index 8d816f519d9e50776f279f80c39267745704000d..24ff37a28c90e1b310b7e76685e383691c8f9559 100644

--- a/apps/app_load_service.cc

+++ b/apps/app_load_service.cc

@@ -47,7 +47,8 @@ void AppLoadService::RestartApplication(const std::string& extension_id) {

ExtensionService* service = extensions::ExtensionSystem::Get(profile_)->

extension_service();

DCHECK(service);

- service->ReloadExtension(extension_id);

+ // Reload the extension and allow noisy notifications.

Devlin 2014/07/02 17:46:50 Nice, but a little verbose. Simply service->Reloa

+ service->ReloadExtension(extension_id, true);

}

bool AppLoadService::LoadAndLaunch(const base::FilePath& extension_path,

« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')