Show alert failure for reloading unpacked extensions with bad manifest

apps/app_load_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/app_load_service.h"
 
 #include "apps/app_load_service_factory.h"
 #include "apps/app_window_registry.h"
 #include "apps/launcher.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 29 matching lines @@
       content::NotificationService::AllSources());
 }
 
 AppLoadService::~AppLoadService() {}
 
 void AppLoadService::RestartApplication(const std::string& extension_id) {
   post_reload_actions_[extension_id].action_type = RESTART;
   ExtensionService* service = extensions::ExtensionSystem::Get(profile_)->
       extension_service();
   DCHECK(service);
-  service->ReloadExtension(extension_id);
+  // Reload the extension and allow noisy notifications.

[Devlin, 2014/07/02 17:46:50]

Nice, but a little verbose.  Simply
service->ReloadExtension(extension_id, true /* be noisy */);
is sufficient.

+  service->ReloadExtension(extension_id, true);
 }
 
 bool AppLoadService::LoadAndLaunch(const base::FilePath& extension_path,
                                    const CommandLine& command_line,
                                    const base::FilePath& current_dir) {
   ExtensionService* extension_service =
       ExtensionSystem::Get(profile_)->extension_service();
   std::string extension_id;
   if (!extensions::UnpackedInstaller::Create(extension_service)->
           LoadFromCommandLine(base::FilePath(extension_path), &extension_id)) {
@@ skipping 76 matching lines @@
         Extension::DISABLE_RELOAD) != 0;
   }
   return false;
 }
 
 bool AppLoadService::HasPostReloadAction(const std::string& extension_id) {
   return post_reload_actions_.find(extension_id) != post_reload_actions_.end();
 }
 
 }  // namespace apps