chrome/browser/ui/views/select_file_dialog_extension.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extension_loader.js ('K') | « chrome/browser/ui/extensions/extension_enable_flow.cc ('k') | chrome/browser/ui/webui/extensions/extension_loader_handler.h » ('j') | chrome/browser/ui/webui/extensions/extension_loader_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc

index d09ced98a5cceb3aad61782f555d4a4b952402c5..94951879a25a04892da7915befebd241076e6ced 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension.cc

@@ -231,7 +231,8 @@ void SelectFileDialogExtension::ExtensionTerminated(

base::Bind(&ExtensionService::ReloadExtension,

base::Unretained(extensions::ExtensionSystem::Get(profile_)

->extension_service()),

- extension_id));

+ extension_id,

+ true));

}

dialog->GetWidget()->Close();