chrome/browser/ui/extensions/extension_enable_flow.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_enable_flow.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extension_loader.js ('K') | « chrome/browser/resources/extensions/extension_loader.js ('k') | chrome/browser/ui/views/select_file_dialog_extension.cc » ('j') | chrome/browser/ui/webui/extensions/extension_loader_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_enable_flow.cc

diff --git a/chrome/browser/ui/extensions/extension_enable_flow.cc b/chrome/browser/ui/extensions/extension_enable_flow.cc

index be3454a04f4c0f9beab76a102f55bb32bcb817ca..08c06be1619349b1ab30061426657955c74614b6 100644

--- a/chrome/browser/ui/extensions/extension_enable_flow.cc

+++ b/chrome/browser/ui/extensions/extension_enable_flow.cc

@@ -64,7 +64,7 @@ void ExtensionEnableFlow::Run() {

if (!extension)

return;

// If the app was terminated, reload it first.

- service->ReloadExtension(extension_id_);

+ service->ReloadExtension(extension_id_, true);

// ReloadExtension reallocates the Extension object.

extension = service->GetExtensionById(extension_id_, true);