chrome/browser/extensions/extension_service_unittest.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.h ('K') | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/extension_util.cc » ('j') | chrome/browser/resources/extensions/extension_loader.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index e8e478ce278c3ced4cb1c302a09721145e84afbd..fd79365b88db14335eeae594e6c38dec4944f47c 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -2845,7 +2845,7 @@ TEST_F(ExtensionServiceTest, LoadExtensionsWithPlugins) {

switches::kAppsGalleryInstallAutoConfirmForTests,

"cancel");

- service()->ReloadExtension(good1);

+ service()->ReloadExtension(good1, true);

base::RunLoop().RunUntilIdle();

EXPECT_EQ(1u, loaded_.size());

EXPECT_EQ(2u, registry()->enabled_extensions().size());

@@ -3527,8 +3527,8 @@ TEST_F(ExtensionServiceTest, ReloadBlacklistedExtension) {

EXPECT_EQ(StringSet(good1, good2),

registry()->blacklisted_extensions().GetIDs());

- service()->ReloadExtension(good1);

- service()->ReloadExtension(good2);

+ service()->ReloadExtension(good1, true);

+ service()->ReloadExtension(good2, true);

base::RunLoop().RunUntilIdle();

EXPECT_EQ(StringSet(good0), registry()->enabled_extensions().GetIDs());

@@ -4064,7 +4064,7 @@ TEST_F(ExtensionServiceTest, ReloadExtension) {

EXPECT_EQ(1u, registry()->enabled_extensions().size());

EXPECT_EQ(0u, registry()->disabled_extensions().size());

- service()->ReloadExtension(extension_id);

+ service()->ReloadExtension(extension_id, true);

// Extension should be disabled now, waiting to be reloaded.

EXPECT_EQ(0u, registry()->enabled_extensions().size());

@@ -4073,7 +4073,7 @@ TEST_F(ExtensionServiceTest, ReloadExtension) {

ExtensionPrefs::Get(profile())->GetDisableReasons(extension_id));

// Reloading again should not crash.

- service()->ReloadExtension(extension_id);

+ service()->ReloadExtension(extension_id, true);

// Finish reloading

base::RunLoop().RunUntilIdle();