chrome/browser/extensions/extension_service.h - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« apps/app_load_service.cc ('K') | « chrome/browser/extensions/extension_error_reporter.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | chrome/browser/resources/extensions/extension_loader.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.h

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h

index 943e3e379605fd5b47114c3c38d0a469770c50f3..1cb8189f154cc59dad753f5b44ad3912fd03f84f 100644

--- a/chrome/browser/extensions/extension_service.h

+++ b/chrome/browser/extensions/extension_service.h

@@ -237,7 +237,7 @@ class ExtensionService

// Reloads the specified extension, sending the onLaunched() event to it if it

// currently has any window showing.

- void ReloadExtension(const std::string& extension_id);

+ void ReloadExtension(const std::string& extension_id, bool be_noisy);

Devlin 2014/07/01 22:14:17 document be_noisy's behavior.

gpdavis 2014/07/01 23:48:09 Done.

// Uninstalls the specified extension. Callers should only call this method

// with extensions that exist. |external_uninstall| is a magical parameter