Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 void SetBeingReloaded(const std::string& extension_id, bool value); 230 void SetBeingReloaded(const std::string& extension_id, bool value);
231 231
232 // Initialize and start all installed extensions. 232 // Initialize and start all installed extensions.
233 void Init(); 233 void Init();
234 234
235 // Called when the associated Profile is going to be destroyed. 235 // Called when the associated Profile is going to be destroyed.
236 void Shutdown(); 236 void Shutdown();
237 237
238 // Reloads the specified extension, sending the onLaunched() event to it if it 238 // Reloads the specified extension, sending the onLaunched() event to it if it
239 // currently has any window showing. 239 // currently has any window showing.
240 void ReloadExtension(const std::string& extension_id); 240 void ReloadExtension(const std::string& extension_id, bool be_noisy);
Devlin 2014/07/01 22:14:17 document be_noisy's behavior.
gpdavis 2014/07/01 23:48:09 Done.
241 241
242 // Uninstalls the specified extension. Callers should only call this method 242 // Uninstalls the specified extension. Callers should only call this method
243 // with extensions that exist. |external_uninstall| is a magical parameter 243 // with extensions that exist. |external_uninstall| is a magical parameter
244 // that is only used to send information to ExtensionPrefs, which external 244 // that is only used to send information to ExtensionPrefs, which external
245 // callers should never set to true. 245 // callers should never set to true.
246 // 246 //
247 // TODO(aa): Remove |external_uninstall| -- this information should be passed 247 // TODO(aa): Remove |external_uninstall| -- this information should be passed
248 // to ExtensionPrefs some other way. 248 // to ExtensionPrefs some other way.
249 virtual bool UninstallExtension(const std::string& extension_id, 249 virtual bool UninstallExtension(const std::string& extension_id,
250 bool external_uninstall, 250 bool external_uninstall,
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 GreylistedExtensionDisabled); 715 GreylistedExtensionDisabled);
716 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 716 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
717 GreylistDontEnableManuallyDisabled); 717 GreylistDontEnableManuallyDisabled);
718 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 718 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
719 GreylistUnknownDontChange); 719 GreylistUnknownDontChange);
720 720
721 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 721 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
722 }; 722 };
723 723
724 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 724 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698