chrome/browser/extensions/extension_browsertest.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« apps/app_load_service.cc ('K') | « chrome/browser/extensions/chrome_extension_web_contents_observer.cc ('k') | chrome/browser/extensions/extension_error_reporter.h » ('j') | chrome/browser/extensions/extension_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index 3443de8f8fc96838f638d26443f677b3f919afa5..63e963432ea1a86a61e65dd2ed4b1b1e2e143e4d 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -201,7 +201,7 @@ ExtensionBrowserTest::LoadExtensionWithInstallParam(

// Reload the extension so that the

// NOTIFICATION_EXTENSION_LOADED_DEPRECATED

// observers may access |install_param|.

- service->ReloadExtension(extension_id);

+ service->ReloadExtension(extension_id, true);

load_signal.Wait();

extension = service->GetExtensionById(extension_id, false);

CHECK(extension) << extension_id << " not found after reloading.";

@@ -535,7 +535,7 @@ void ExtensionBrowserTest::ReloadExtension(const std::string extension_id) {

ExtensionService* service =

extensions::ExtensionSystem::Get(profile())->extension_service();

- service->ReloadExtension(extension_id);

+ service->ReloadExtension(extension_id, true);

observer_->Wait();

observer_->WaitForExtensionViewsToLoad();