chrome/browser/background/background_contents_service.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« apps/app_load_service.cc ('K') | « apps/app_load_service.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | chrome/browser/extensions/extension_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents_service.cc

diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc

index 687d87a3103434423a56b6021e37d3c9bd2bd2c5..6577441fbfd1e57ec37ca9d3238ab581a41250ed 100644

--- a/chrome/browser/background/background_contents_service.cc

+++ b/chrome/browser/background/background_contents_service.cc

@@ -129,7 +129,7 @@ class CrashNotificationDelegate : public NotificationDelegate {

RestartApplication(copied_extension_id);

} else {

extensions::ExtensionSystem::Get(profile_)->extension_service()->

- ReloadExtension(copied_extension_id);

+ ReloadExtension(copied_extension_id, true);

}

// Closing the crash notification balloon for the app/extension here should

@@ -237,7 +237,7 @@ void ReloadExtension(const std::string& extension_id, Profile* profile) {

// been restarted successfully by someone else (the user).

return;

}

- extension_system->extension_service()->ReloadExtension(extension_id);

+ extension_system->extension_service()->ReloadExtension(extension_id, true);

}

} // namespace