Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 341973003: ARM HW bots: looks for FEATURE_VERSION in the right place (Closed)

Created:
6 years, 6 months ago by Derek Schuff
Modified:
6 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

ARM HW bots: looks for FEATURE_VERSION in the right place The ARM HW bots weren't running SIMD tests because they weren't looking for the FEATURE_VERSION file at the right place: they were looking in pnacl_newlib instead of pnacl_translator, and the former doesn't exist on ARM hardware. So, fall back to pnacl_translator/FEATURE_VERSION if pnacl_newlib doesn't exist. R=jvoung@chromium.org, jfb@chromium.org BUG=nativeclient:2205 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13376

Patch Set 1 #

Total comments: 1

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M site_scons/site_tools/naclsdk.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
Cloning the CL from https://codereview.chromium.org/331933002/
6 years, 6 months ago (2014-06-18 18:37:52 UTC) #1
jvoung (off chromium)
lgtm https://codereview.chromium.org/341973003/diff/1/site_scons/site_tools/naclsdk.py File site_scons/site_tools/naclsdk.py (right): https://codereview.chromium.org/341973003/diff/1/site_scons/site_tools/naclsdk.py#newcode681 site_scons/site_tools/naclsdk.py:681: if not os.path.exists(version_file): Leave a comment about why ...
6 years, 6 months ago (2014-06-18 18:54:15 UTC) #2
Derek Schuff
6 years, 6 months ago (2014-06-18 22:16:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698