Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 331933002: ARM HW bots: looks for FEATURE_VERSION in the right place (Closed)

Created:
6 years, 6 months ago by JF
Modified:
6 years, 6 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

The ARM HW bots weren't running SIMD tests because they weren't looking for the FEATURE_VERSION file at the right place: they were looking in pnacl_newlib instead of pnacl_translator, and the former only exists if the build was local. R= dschuff@chromium.org TEST= git try -b nacl-arm_opt_panda BUG= none

Patch Set 1 #

Patch Set 2 : print print print #

Patch Set 3 : Fix root. #

Patch Set 4 : Remove print. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M site_scons/site_tools/naclsdk.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
JF
dschuff: the fix we discussed doesn't seem to have fixed the issue, feature version is ...
6 years, 6 months ago (2014-06-14 01:01:23 UTC) #1
Derek Schuff
On 2014/06/14 01:01:23, JF wrote: > dschuff: the fix we discussed doesn't seem to have ...
6 years, 6 months ago (2014-06-17 21:58:27 UTC) #2
JF
> I think it works (seems to work locally) but we still need to put ...
6 years, 6 months ago (2014-06-17 22:10:42 UTC) #3
Derek Schuff
Yeah, I just noticed that for some reason it was missing on my local build. ...
6 years, 6 months ago (2014-06-17 22:15:06 UTC) #4
Derek Schuff
On 2014/06/17 22:15:06, Derek Schuff wrote: > Yeah, I just noticed that for some reason ...
6 years, 6 months ago (2014-06-17 23:33:51 UTC) #5
JF
6 years, 6 months ago (2014-06-24 00:20:53 UTC) #6
Message was sent while issue was closed.
Closing, dschuff fixed this in https://codereview.chromium.org/341973003/

Powered by Google App Engine
This is Rietveld 408576698