Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Issue 341923004: [webcrypto] Don't execute cancelled crypto operations. (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Don't execute cancelled crypto operations. BUG=375430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278274

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/child/webcrypto/webcrypto_impl.cc View 1 11 chunks +28 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
eroman
The corresponding Blink side of this change is: https://codereview.chromium.org/343723003
6 years, 6 months ago (2014-06-18 20:08:44 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/341923004/diff/20001/content/child/webcrypto/webcrypto_impl.cc File content/child/webcrypto/webcrypto_impl.cc (right): https://codereview.chromium.org/341923004/diff/20001/content/child/webcrypto/webcrypto_impl.cc#newcode175 content/child/webcrypto/webcrypto_impl.cc:175: return result.cancelled(); Is this really safe? Seems like we ...
6 years, 6 months ago (2014-06-18 23:59:52 UTC) #2
Ryan Sleevi
Never mind, saw the comment on the WebKit side. LGTM, although boo on atomics :/
6 years, 6 months ago (2014-06-19 00:02:46 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-19 03:43:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/341923004/20001
6 years, 6 months ago (2014-06-19 03:44:47 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 04:51:22 UTC) #6
Message was sent while issue was closed.
Change committed as 278274

Powered by Google App Engine
This is Rietveld 408576698