Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 343723003: [webcrypto] Allow crypto operations to be cancelled by the platform implementation. (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Project:
blink
Visibility:
Public.

Description

[webcrypto] Allow crypto operations to be cancelled by the platform implementation. When the ExecutionContext is destroyed, the outstanding request is marked as cancelled. The corresponding chromium side of this change is https://codereview.chromium.org/341923004/ BUG=375430 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176502

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -14 lines) Patch
A LayoutTests/crypto/abandon-crypto-operation2.html View 1 chunk +54 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/abandon-crypto-operation2-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
A LayoutTests/crypto/resources/worker-start-slow-operations.js View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/modules/crypto/CryptoResultImpl.cpp View 2 chunks +24 lines, -10 lines 0 comments Download
M Source/platform/CryptoResult.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/exported/WebCryptoResult.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eroman
6 years, 6 months ago (2014-06-18 20:14:43 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-19 02:07:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/343723003/1
6 years, 6 months ago (2014-06-19 02:08:15 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 03:20:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/9564)
6 years, 6 months ago (2014-06-19 03:20:48 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-19 06:59:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/343723003/20001
6 years, 6 months ago (2014-06-19 07:00:35 UTC) #7
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 6 months ago (2014-06-19 07:00:57 UTC) #8
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-19 07:06:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/343723003/40001
6 years, 6 months ago (2014-06-19 07:07:35 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 11:57:35 UTC) #11
Message was sent while issue was closed.
Change committed as 176502

Powered by Google App Engine
This is Rietveld 408576698