[PowerProfiler] Power profiler service keeps running even after devtools frontend has been closed.

[PowerProfiler] Power profiler service keeps running even after devtools frontend has been closed.

This is happening as the power handler is not listening to the frontend close events. When the front-end is closed, the service is unaware of this and it keeps collecting the data. With the active frontend close, the devtools power handler should unregister itself with the service.

BUG=386175
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279068

[vivekg, 2014-06-18 15:10:06]

PTAL, thank you.

[yurys, 2014-06-18 15:20:59]

lgtm

https://codereview.chromium.org/341853002/diff/1/content/browser/devtools/dev...
File content/browser/devtools/devtools_power_handler.h (right):

https://codereview.chromium.org/341853002/diff/1/content/browser/devtools/dev...
content/browser/devtools/devtools_power_handler.h:21:
DevToolsPowerHandler(DevToolsAgentHost*);
should be explicit

[vivekg, 2014-06-18 15:54:34]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2014-06-18 15:54:52]

On 2014/06/18 15:20:59, yurys wrote:
> lgtm
> 
>
https://codereview.chromium.org/341853002/diff/1/content/browser/devtools/dev...
> File content/browser/devtools/devtools_power_handler.h (right):
> 
>
https://codereview.chromium.org/341853002/diff/1/content/browser/devtools/dev...
> content/browser/devtools/devtools_power_handler.h:21:
> DevToolsPowerHandler(DevToolsAgentHost*);
> should be explicit

Done, thank you!

[commit-bot: I haz the power, 2014-06-18 15:55:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/341853002/20001

[vivekg, 2014-06-18 16:20:36]

The CQ bit was unchecked by vivekg@chromium.org

[vivekg, 2014-06-18 16:20:59]

This patch has dependency on https://codereview.chromium.org/332623003/ to be
landed first.

[yurys, 2014-06-19 14:07:03]

After reviewing https://codereview.chromium.org/337213005/ I realized that
instead of listening to AgentState changes which we are going to remove we could
introduce OnCliendDetached method on DevToolsTracingHandler and have it called
from RenderViewDevToolsAgentHost::OnClientDetached like we already do with
overrides handler.

[vivekg, 2014-06-23 06:03:26]

On 2014/06/19 14:07:03, yurys wrote:
> After reviewing https://codereview.chromium.org/337213005/ I realized that
> instead of listening to AgentState changes which we are going to remove we
could
> introduce OnCliendDetached method on DevToolsTracingHandler and have it called
> from RenderViewDevToolsAgentHost::OnClientDetached like we already do with
> overrides handler.

With the crash fix landed [1], I have rebased this CL with your comments
addressed. PTAL. 

[1] https://codereview.chromium.org/332623003/

[yurys, 2014-06-23 07:08:48]

Patch set #3 - lgtm

[vivekg, 2014-06-23 07:37:26]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-06-23 07:38:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/341853002/40001

[commit-bot: I haz the power, 2014-06-23 09:43:27]

Change committed as 279068