content/browser/devtools/devtools_power_handler.cc - Issue 341853002: [PowerProfiler] Power profiler service keeps running even after devtools frontend has been closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_power_handler.cc

Issue 341853002: [PowerProfiler] Power profiler service keeps running even after devtools frontend has been closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@power-profiler-devtools-crash-fix

Patch Set: Patch for landing! Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_power_handler.h ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_power_handler.cc

diff --git a/content/browser/devtools/devtools_power_handler.cc b/content/browser/devtools/devtools_power_handler.cc

index 43772b47607e2dddd54bd4cab003f3f8f5716e3d..8915c03e8f1da81cbd04d1a63fae39e7a575146c 100644

--- a/content/browser/devtools/devtools_power_handler.cc

+++ b/content/browser/devtools/devtools_power_handler.cc

@@ -80,4 +80,8 @@ DevToolsPowerHandler::OnCanProfilePower(

return command->SuccessResponse(result);

}

+void DevToolsPowerHandler::OnClientDetached() {

+ PowerProfilerService::GetInstance()->RemoveObserver(this);

} // namespace content

« no previous file with comments | « content/browser/devtools/devtools_power_handler.h ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | no next file with comments »