Improve factory screen brightness

Improve factory screen brightness

Changes to chromeos-init ebuild file is in a separate change list.
See: http://codereview.chromium.org/3443024

BUG=chrome-os-partner:1107
TEST=manual

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7f05efb

[Tammo Spalink, 2010-09-25 03:07:49]

lets wait to commit this until we know if this can be fixed in firmware

Tammo

On Fri, Sep 24, 2010 at 17:48,  <clchiou@chromium.org> wrote:
> Reviewers: Tom Wai-Hong Tam, Tammo Spalink,
>
> Description:
> Improve factory screen brightness
>
> BUG=chrome-os-partner:1107
> TEST=manual
>
> Please review this at http://codereview.chromium.org/3418029/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/init.git
>
> Affected files:
>  M chromeos_startup
>  A lightup_screen
>
>
> Index: chromeos_startup
> diff --git a/chromeos_startup b/chromeos_startup
> index
>
0b1e6c66675401c6d6f0fa61dadd7f4f47985d27..10655cf9d718e001d185a304f620e52990a7c619
> 100755
> --- a/chromeos_startup
> +++ b/chromeos_startup
> @@ -74,6 +74,9 @@ fi
>  RESET_FILE="/mnt/stateful_partition/factory_install_reset"
>  if [ -f "$RESET_FILE" ]; then
>   if [ $(stat -c%u "$RESET_FILE") -eq 0 ]; then
> +    # Light up screen in case you can't see our splash image.
> +    /sbin/lightup_screen
> +
>     echo "Erasing stateful partition..."
>     # Show a splash image to inform OPs it is wiping the disk.
>     if [ -x /usr/bin/ply-image ]; then
> Index: lightup_screen
> diff --git a/lightup_screen b/lightup_screen
> new file mode 100755
> index
>
0000000000000000000000000000000000000000..ec57c02c687f79755c2e65685d9383005d79759b
> --- /dev/null
> +++ b/lightup_screen
> @@ -0,0 +1,27 @@
> +#!/bin/sh
> +
> +# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +# Always exit with 0
> +trap "exit 0" EXIT
> +set -e
> +
> +for INTERFACE in "acpi_video0" "i915_backlight"; do
> +       BRIGHTNESS="/sys/class/backlight/${INTERFACE}/brightness"
> +       MAX_BRIGHTNESS="/sys/class/backlight/${INTERFACE}/max_brightness"
> +
> +       [ ! -f "${BRIGHTNESS}" -o ! -f "${MAX_BRIGHTNESS}" ] && continue
> +
> +       MAXB=$(cat "${MAX_BRIGHTNESS}")
> +       if [ "${INTERFACE}" = "acpi_video0" ]; then
> +               B="${MAXB}"
> +       else
> +               B="$((${MAXB}-1))"
> +       fi
> +
> +       echo "${B}" > "${BRIGHTNESS}"
> +
> +       break
> +done
>
>
>

[Tammo Spalink, 2010-10-01 06:29:51]

lgtm -- but please move the lightup_screen script into /usr/sbin

[Che-Liang Chiou, 2010-10-01 08:21:36]

Change to /usr/sbin.  Submit after the ebuild CL.

On 2010/10/01 06:29:51, Tammo Spalink wrote:
> lgtm -- but please move the lightup_screen script into /usr/sbin

[Tom Wai-Hong Tam, 2010-10-01 18:58:40]

LGTM