Improve factory screen brightness

Improve factory screen brightness

The script lightup_screen is in a separate change list.
See http://codereview.chromium.org/3418029

BUG=chrome-os-partner:1107
TEST=manual

Change-Id: I1e8aa1c029bde9618d38094f13db65ec09498ea8

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=28c1ca2

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f7e63f3

[Tammo Spalink, 2010-09-25 03:08:30]

lets wait to commit this until we know if this can be fixed in firmware

Tammo

On Fri, Sep 24, 2010 at 17:53,  <clchiou@chromium.org> wrote:
> Reviewers: Mandeep Singh Baines, Tammo Spalink,
>
> Description:
> Improve factory screen brightness
>
> BUG=chrome-os-partner:1107
> TEST=manual
>
> Change-Id: I1e8aa1c029bde9618d38094f13db65ec09498ea8
>
> Please review this at http://codereview.chromium.org/3443024/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git
>
> Affected files:
>  M chromeos-base/chromeos-init/chromeos-init-9999.ebuild
>
>
> Index: chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> diff --git a/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> b/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> index
>
259f32a0589f34fa4de66c84263a0b28be2044af..a3b7b6a8e251aac9fd582dd0e9a18a195b89bb2f
> 100644
> --- a/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> +++ b/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> @@ -49,6 +49,7 @@ src_install() {
>
>        # Install startup/shutdown scripts.
>        dosbin "${S}/chromeos_startup" "${S}/chromeos_shutdown"
> +       dosbin "${S}/lightup_screen"
>        dosbin "${S}/clobber-state"
>
>         # Install log cleaning script and run it daily.
>
>
>

[Tammo Spalink, 2010-10-01 06:33:50]

Ok, we do want this file -- but I am not really qualified to lgtm ebuild files,
so I added some other people.

On 2010/09/25 03:08:30, Tammo Spalink wrote:
> lets wait to commit this until we know if this can be fixed in firmware
> 
> Tammo
> 
> On Fri, Sep 24, 2010 at 17:53,  <mailto:clchiou@chromium.org> wrote:
> > Reviewers: Mandeep Singh Baines, Tammo Spalink,
> >
> > Description:
> > Improve factory screen brightness
> >
> > BUG=chrome-os-partner:1107
> > TEST=manual
> >
> > Change-Id: I1e8aa1c029bde9618d38094f13db65ec09498ea8
> >
> > Please review this at http://codereview.chromium.org/3443024/show
> >
> > SVN Base: ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git
> >
> > Affected files:
> > &nbsp;M chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> >
> >
> > Index: chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> > diff --git a/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> > b/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> > index
> >
>
259f32a0589f34fa4de66c84263a0b28be2044af..a3b7b6a8e251aac9fd582dd0e9a18a195b89bb2f
> > 100644
> > --- a/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> > +++ b/chromeos-base/chromeos-init/chromeos-init-9999.ebuild
> > @@ -49,6 +49,7 @@ src_install() {
> >
> > &nbsp; &nbsp; &nbsp; &nbsp;# Install startup/shutdown scripts.
> > &nbsp; &nbsp; &nbsp; &nbsp;dosbin "${S}/chromeos_startup"
"${S}/chromeos_shutdown"
> > + &nbsp; &nbsp; &nbsp; dosbin "${S}/lightup_screen"
> > &nbsp; &nbsp; &nbsp; &nbsp;dosbin "${S}/clobber-state"
> >
> > &nbsp; &nbsp; &nbsp; &nbsp; # Install log cleaning script and run it daily.
> >
> >
> >
>

[Tom Wai-Hong Tam, 2010-10-01 19:00:27]

You also need to change
chromeos-base/chromeos-init/chromeos-init-0.0.1-r119.ebuild too.

[Che-Liang Chiou, 2010-10-04 02:24:29]

This file was autogenerated by chrome-bot.  It will show up (with version
bumped) after I push this CL.

On 2010/10/01 19:00:27, Tom Wai-Hong Tam wrote:
> You also need to change
> chromeos-base/chromeos-init/chromeos-init-0.0.1-r119.ebuild too.

[Tom Wai-Hong Tam, 2010-10-05 00:07:44]

You are right.

LGTM.