Issue 341713008: Fix crash in ScriptDebugServer::setBreakpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341713008: Fix crash in ScriptDebugServer::setBreakpoint (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
vsevik, aandrey

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix crash in ScriptDebugServer::setBreakpoint The crash was presumably caused by breakpointId handle being null because of exception in debugger. Generally debugger calls shouldn't throw but since some parts of it are implemented in JS there may be a stack overflow which would result in an exception and empty result handle. BUG=381567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176402

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/v8/ScriptDebugServer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/341713008/1

6 years, 6 months ago (2014-06-18 07:41:41 UTC) #4

Message was sent while issue was closed.

Change committed as 176402

Expand Messages | Collapse Messages