Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 341713008: Fix crash in ScriptDebugServer::setBreakpoint (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp
index 7d70115a0261404e946d46038f45fb408e97534a..97fd008af4b04ab767fb90f777716653cb833dbb 100644
--- a/Source/bindings/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/v8/ScriptDebugServer.cpp
@@ -100,7 +100,7 @@ String ScriptDebugServer::setBreakpoint(const String& sourceID, const ScriptBrea
v8::Handle<v8::Function> setBreakpointFunction = v8::Local<v8::Function>::Cast(m_debuggerScript.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "setBreakpoint")));
v8::Handle<v8::Value> breakpointId = v8::Debug::Call(setBreakpointFunction, info);
- if (!breakpointId->IsString())
+ if (breakpointId.IsEmpty() || !breakpointId->IsString())
return "";
*actualLineNumber = info->Get(v8AtomicString(m_isolate, "lineNumber"))->Int32Value();
*actualColumnNumber = info->Get(v8AtomicString(m_isolate, "columnNumber"))->Int32Value();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698