Create scanout buffer in GbmSurfaceFactory.

Create scanout buffer in GbmSurfaceFactory.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278209

[alexst (slow to review), 2014-06-17 17:29:21]

Using my BufferData refactor.

[dnicoara, 2014-06-17 18:16:43]

lgtm

https://codereview.chromium.org/341603002/diff/1/ui/ozone/platform/dri/gbm_su...
File ui/ozone/platform/dri/gbm_surface_factory.cc (right):

https://codereview.chromium.org/341603002/diff/1/ui/ozone/platform/dri/gbm_su...
ui/ozone/platform/dri/gbm_surface_factory.cc:159: switch (format) {
Should we have XRGB8888 in here for 32 bpp support? That's what I've seen being
used most of the time. I suppose we don't need it for overlays, but wondering if
you're planing on using CreateNativeBuffer for the primary plane as well? We
might want it then.

https://codereview.chromium.org/341603002/diff/1/ui/ozone/platform/dri/gbm_su...
ui/ozone/platform/dri/gbm_surface_factory.cc:174: GBM_BO_USE_SCANOUT |
GBM_BO_USE_RENDERING | 0);
nit: Don't need "| 0" at the end.

[alexst (slow to review), 2014-06-17 18:31:34]

> Should we have XRGB8888 in here for 32 bpp support? That's what I've seen
being
> used most of the time. I suppose we don't need it for overlays, but wondering
if
> you're planing on using CreateNativeBuffer for the primary plane as well? We
> might want it then.

Good point, it's meant for primary planes too.

[dnicoara, 2014-06-17 21:15:09]

https://codereview.chromium.org/341603002/diff/20001/ui/ozone/platform/dri/gb...
File ui/ozone/platform/dri/gbm_surface_factory.cc (right):

https://codereview.chromium.org/341603002/diff/20001/ui/ozone/platform/dri/gb...
ui/ozone/platform/dri/gbm_surface_factory.cc:163: gbm_format =
GBM_FORMAT_XRGB8888;
I was thinking of having another case statement. We definitely don't want to do
this since we want to support transparency in overlays.

[alexst (slow to review), 2014-06-17 21:37:29]

On 2014/06/17 21:15:09, dnicoara wrote:
>
https://codereview.chromium.org/341603002/diff/20001/ui/ozone/platform/dri/gb...
> File ui/ozone/platform/dri/gbm_surface_factory.cc (right):
> 
>
https://codereview.chromium.org/341603002/diff/20001/ui/ozone/platform/dri/gb...
> ui/ozone/platform/dri/gbm_surface_factory.cc:163: gbm_format =
> GBM_FORMAT_XRGB8888;
> I was thinking of having another case statement. We definitely don't want to
do
> this since we want to support transparency in overlays.

Right, what if the primary plane needs to be transparent to show a video
underneath? Let's keep it ARGB for now and see if there are issue with that for
primary plane.

[alexst (slow to review), 2014-06-17 22:00:06]

On 2014/06/17 21:37:29, alexst wrote:
> On 2014/06/17 21:15:09, dnicoara wrote:
> >
>
https://codereview.chromium.org/341603002/diff/20001/ui/ozone/platform/dri/gb...
> > File ui/ozone/platform/dri/gbm_surface_factory.cc (right):
> > 
> >
>
https://codereview.chromium.org/341603002/diff/20001/ui/ozone/platform/dri/gb...
> > ui/ozone/platform/dri/gbm_surface_factory.cc:163: gbm_format =
> > GBM_FORMAT_XRGB8888;
> > I was thinking of having another case statement. We definitely don't want to
> do
> > this since we want to support transparency in overlays.
> 
> Right, what if the primary plane needs to be transparent to show a video
> underneath? Let's keep it ARGB for now and see if there are issue with that
for
> primary plane.

Scratch that, after talking to dnicoara, we'll allow primary scanout and disable
overlay transparency for the time being and fix this
either by introducing a new format string into the command buffer API or
addressing this limitation in DRM.

[dnicoara, 2014-06-17 22:01:05]

lgtm

[rjkroege, 2014-06-18 15:10:23]

lgtm

[alexst (slow to review), 2014-06-18 15:14:10]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-06-18 15:15:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/341603002/60001

[commit-bot: I haz the power, 2014-06-19 01:01:49]

Change committed as 278209