Theme Preferences for Distilled Pages

chrome/browser/dom_distiller/lazy_dom_distiller_service.cc

Index: chrome/browser/dom_distiller/lazy_dom_distiller_service.cc
diff --git a/chrome/browser/dom_distiller/lazy_dom_distiller_service.cc b/chrome/browser/dom_distiller/lazy_dom_distiller_service.cc
index 3e7e74573a3ff01af226eebf8f8085897d7c8efc..70b611370357ae708ef6302166d04c1f5a982b03 100644
--- a/chrome/browser/dom_distiller/lazy_dom_distiller_service.cc
+++ b/chrome/browser/dom_distiller/lazy_dom_distiller_service.cc
@@ -9,6 +9,7 @@
 #include "chrome/browser/profiles/profile.h"
 #include "components/dom_distiller/core/distiller_page.h"
 #include "components/dom_distiller/core/dom_distiller_service.h"
+#include "components/dom_distiller/core/reader_mode_preferences.h"
 #include "content/public/browser/notification_source.h"
 
 namespace dom_distiller {
@@ -20,6 +21,7 @@ LazyDomDistillerService::LazyDomDistillerService(
   registrar_.Add(this,
                  chrome::NOTIFICATION_PROFILE_DESTROYED,
                  content::Source<Profile>(profile));
+  reader_mode_prefs_.reset(new ReaderModePrefs(profile_));

[battre, 2014/06/23 08:37:23]

Move this after service_factory_(service_factory) ?

[nyquist, 2014/06/23 16:03:05]

Also, like battre has mentioned, this is probably not needed. Doing this here,
creates another ReaderModePrefs, which might explain what you were seeing last
week.

[smaslo, 2014/06/23 22:14:32]

Removed completely.

[smaslo, 2014/06/23 22:14:32]

Done.

 }
 
 LazyDomDistillerService::~LazyDomDistillerService() {
@@ -93,4 +95,8 @@ void LazyDomDistillerService::RemoveObserver(DomDistillerObserver* observer) {
   instance()->RemoveObserver(observer);
 }
 
+ReaderModePrefs* LazyDomDistillerService::GetReaderModePrefs() const {
+  return reader_mode_prefs_.get();

[nyquist, 2014/06/23 16:03:05]

This could probably just delegate to the DomDistillerService, by calling
instance()->...

[smaslo, 2014/06/23 22:14:32]

Done.

+}
+
 }  // namespace dom_distiller