Theme Preferences for Distilled Pages

chrome/browser/dom_distiller/lazy_dom_distiller_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_distiller/lazy_dom_distiller_service.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/dom_distiller/dom_distiller_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/dom_distiller/core/distiller_page.h"
 #include "components/dom_distiller/core/dom_distiller_service.h"
+#include "components/dom_distiller/core/reader_mode_preferences.h"
 #include "content/public/browser/notification_source.h"
 
 namespace dom_distiller {
 
 LazyDomDistillerService::LazyDomDistillerService(
     Profile* profile,
     const DomDistillerServiceFactory* service_factory)
     : profile_(profile), service_factory_(service_factory) {
   registrar_.Add(this,
                  chrome::NOTIFICATION_PROFILE_DESTROYED,
                  content::Source<Profile>(profile));
+  reader_mode_prefs_.reset(new ReaderModePrefs(profile_));

[battre, 2014/06/23 08:37:23]

Move this after service_factory_(service_factory) ?

[nyquist, 2014/06/23 16:03:05]

Also, like battre has mentioned, this is probably not needed. Doing this here,
creates another ReaderModePrefs, which might explain what you were seeing last
week.

[smaslo, 2014/06/23 22:14:32]

Removed completely.

[smaslo, 2014/06/23 22:14:32]

Done.

 }
 
 LazyDomDistillerService::~LazyDomDistillerService() {
 }
 
 // This will create an object and schedule work the first time it's called
 // and just return an existing object after that.
 DomDistillerServiceInterface* LazyDomDistillerService::instance() const {
   return service_factory_->GetForBrowserContext(profile_);
 }
@@ skipping 53 matching lines @@
 }
 
 void LazyDomDistillerService::AddObserver(DomDistillerObserver* observer) {
   instance()->AddObserver(observer);
 }
 
 void LazyDomDistillerService::RemoveObserver(DomDistillerObserver* observer) {
   instance()->RemoveObserver(observer);
 }
 
+ReaderModePrefs* LazyDomDistillerService::GetReaderModePrefs() const {
+  return reader_mode_prefs_.get();

[nyquist, 2014/06/23 16:03:05]

This could probably just delegate to the DomDistillerService, by calling
instance()->...

[smaslo, 2014/06/23 22:14:32]

Done.

+}
+
 }  // namespace dom_distiller