Issue 341543005: Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341543005: Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader. (Closed)

Created:
6 years, 6 months ago by humper

Modified:
6 years, 6 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader. approved over in https://codereview.chromium.org/331863006/; reuploading because it had the wrong base url BUG=skia:2095 TBR=bsalomon Committed: https://skia.googlesource.com/skia/+/4a24cd8ff41a8b3d292d60e4351a631240a7ed75

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -101 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	8 chunks	+92 lines, -94 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/BlurTest.cpp	View	4 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/341543005/1

6 years, 6 months ago (2014-06-17 19:47:44 UTC) #2

commit-bot: I haz the power

6 years, 6 months ago (2014-06-17 20:39:42 UTC) #3

Message was sent while issue was closed.

Change committed as 4a24cd8ff41a8b3d292d60e4351a631240a7ed75