src/gpu/gl/GrGLShaderBuilder.cpp - Issue 341543005: Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLShaderBuilder.cpp

Issue 341543005: Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/gl/GrGLShaderBuilder.cpp

diff --git a/src/gpu/gl/GrGLShaderBuilder.cpp b/src/gpu/gl/GrGLShaderBuilder.cpp

index f8f810ff78a8967e612cfd7adb99e1e44d9300c7..4b2778c50308ae0838d6f73cf84af4c9d04d5279 100644

--- a/src/gpu/gl/GrGLShaderBuilder.cpp

+++ b/src/gpu/gl/GrGLShaderBuilder.cpp

@@ -216,7 +216,7 @@ bool GrGLShaderBuilder::genProgram(const GrEffectStage* colorStages[],

if (GrGLProgramDesc::kSecondaryCoverageISA_CoverageOutput == header.fCoverageOutput) {

// Get (1-A) into coeff

coeff = GrGLSLExpr4::VectorCast(GrGLSLExpr1(1) - inputColor.a());

- } else if (GrGLProgramDesc::kSecondaryCoverageISC_CoverageOutput ==

+ } else if (GrGLProgramDesc::kSecondaryCoverageISC_CoverageOutput ==

header.fCoverageOutput){

// Get (1-RGBA) into coeff

coeff = GrGLSLExpr4(1) - inputColor;

« no previous file with comments | « src/effects/SkBlurMaskFilter.cpp ('k') | tests/BlurTest.cpp » ('j') | no next file with comments »