Issue 341543003: DevTools: make responsive design a master switch for emulation.

Issue 341543003: DevTools: make responsive design a master switch for emulation. (Closed)

Created:
6 years, 6 months ago by pfeldman

Modified:
6 years, 6 months ago

Reviewers:
dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: make responsive design a master switch for emulation. BUG=327641 R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176340

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -58 lines)			Patch
M	Source/devtools/front_end/ResponsiveDesignView.js	View	1 2 3 4	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/devtools/front_end/common/Settings.js	View	1 2 3 4	2 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/elements/OverridesView.js	View		7 chunks	+17 lines, -22 lines	0 comments	Download
M	Source/devtools/front_end/main/AdvancedApp.js	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/overrides.css	View		5 chunks	+15 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/sdk/OverridesSupport.js	View	1 2 3 4	12 chunks	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgozman

https://codereview.chromium.org/341543003/diff/40001/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (right): https://codereview.chromium.org/341543003/diff/40001/Source/devtools/front_end/main/AdvancedApp.js#newcode31 Source/devtools/front_end/main/AdvancedApp.js:31: this._toggleResponsiveDesignButton.toggled = WebInspector.settings.responsiveDesignEnabled.get(); Let's show/hide emulation tab in drawer ...

6 years, 6 months ago (2014-06-17 16:20:48 UTC) #2

pfeldman

Fixed... https://codereview.chromium.org/341543003/diff/40001/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (right): https://codereview.chromium.org/341543003/diff/40001/Source/devtools/front_end/main/AdvancedApp.js#newcode31 Source/devtools/front_end/main/AdvancedApp.js:31: this._toggleResponsiveDesignButton.toggled = WebInspector.settings.responsiveDesignEnabled.get(); On 2014/06/17 16:20:48, dgozman wrote: ...

6 years, 6 months ago (2014-06-17 16:25:04 UTC) #3

pfeldman

6 years, 6 months ago (2014-06-17 17:26:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r176340 (presubmit successful).

Expand Messages | Collapse Messages