Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 341543003: DevTools: make responsive design a master switch for emulation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/common/Settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ResponsiveDesignView.js
diff --git a/Source/devtools/front_end/ResponsiveDesignView.js b/Source/devtools/front_end/ResponsiveDesignView.js
index 6b3a9dee3ac43c2fc11ef8dcec3b3e6f1182d405..581f5081c136772a575887b978e29d900624deb0 100644
--- a/Source/devtools/front_end/ResponsiveDesignView.js
+++ b/Source/devtools/front_end/ResponsiveDesignView.js
@@ -47,7 +47,7 @@ WebInspector.ResponsiveDesignView = function(inspectedPagePlaceholder)
this._enabled = false;
WebInspector.zoomManager.addEventListener(WebInspector.ZoomManager.Events.ZoomChanged, this._onZoomChanged, this);
- WebInspector.settings.responsiveDesign.enabled.addChangeListener(this._responsiveDesignEnabledChanged, this);
+ WebInspector.settings.responsiveDesignEnabled.addChangeListener(this._responsiveDesignEnabledChanged, this);
this._responsiveDesignEnabledChanged();
this._overridesWarningUpdated();
};
@@ -70,7 +70,7 @@ WebInspector.ResponsiveDesignView.prototype = {
_responsiveDesignEnabledChanged: function()
{
- var enabled = WebInspector.settings.responsiveDesign.enabled.get();
+ var enabled = WebInspector.settings.responsiveDesignEnabled.get();
if (enabled && !this._enabled) {
this._invalidateCache();
this._ignoreResize = true;
@@ -380,12 +380,12 @@ WebInspector.ResponsiveDesignView.prototype = {
this._expandedNetworkSection = document.createElementWithClass("div", "responsive-design-composite-section vbox solid");
this._expandSection = document.createElementWithClass("div", "responsive-design-section vbox");
- WebInspector.settings.responsiveDesign.toolbarExpanded = WebInspector.settings.createSetting("responsiveDesign.toolbarExpanded", false);
+ this.toolbarExpandedSetting = WebInspector.settings.createSetting("responsiveDesignToolbarExpanded", false);
this._expandButton = this._expandSection.createChild("div", "responsive-design-expand");
this._expandButton.createChild("div", "responsive-design-icon responsive-design-icon-expand");
this._expandButton.createChild("span");
this._expandButton.addEventListener("click", this._toggleToolbarExpanded.bind(this), false);
- WebInspector.settings.responsiveDesign.toolbarExpanded.addChangeListener(this._toolbarExpandedChanged, this);
+ this.toolbarExpandedSetting.addChangeListener(this._toolbarExpandedChanged, this);
// Device
this._deviceSection = document.createElementWithClass("div", "responsive-design-section");
@@ -449,12 +449,12 @@ WebInspector.ResponsiveDesignView.prototype = {
_toggleToolbarExpanded: function()
{
- WebInspector.settings.responsiveDesign.toolbarExpanded.set(!WebInspector.settings.responsiveDesign.toolbarExpanded.get());
+ this.toolbarExpandedSetting.set(!this.toolbarExpandedSetting.get());
},
_toolbarExpandedChanged: function()
{
- var expanded = WebInspector.settings.responsiveDesign.toolbarExpanded.get();
+ var expanded = this.toolbarExpandedSetting.get();
this._expandButton.classList.toggle("expanded", expanded);
this._expandButton.querySelector("span").textContent = WebInspector.UIString(expanded ? "Collapse" : "Expand");
« no previous file with comments | « no previous file | Source/devtools/front_end/common/Settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698