Issue 341433003: Oilpan: Prepare to move ScriptedAnimationController to Oilpan heap.

Issue 341433003: Oilpan: Prepare to move ScriptedAnimationController to Oilpan heap. (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, shans, rjwright, dstockwell, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, Timothy Loh, Mike Lawther (Google), blink-reviews-dom_chromium.org, dglazkov+blink, Steve Block, darktears, Eric Willigers, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Prepare to move ScriptedAnimationController to Oilpan heap. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176291

Patch Set 1 #

Total comments: 3

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -9 lines)			Patch
M	Source/core/dom/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/ScriptedAnimationController.h	View	2 chunks	+8 lines, -7 lines	3 comments	Download
M	Source/core/dom/ScriptedAnimationController.cpp	View	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM. https://codereview.chromium.org/341433003/diff/1/Source/core/dom/ScriptedAnimationController.h File Source/core/dom/ScriptedAnimationController.h (right): https://codereview.chromium.org/341433003/diff/1/Source/core/dom/ScriptedAnimationController.h#newcode43 Source/core/dom/ScriptedAnimationController.h:43: class ScriptedAnimationController : public RefCountedWillBeGarbageCollectedFinalized<ScriptedAnimationController> { Can this ...

6 years, 6 months ago (2014-06-17 06:44:48 UTC) #2

tkent

https://codereview.chromium.org/341433003/diff/1/Source/core/dom/ScriptedAnimationController.h File Source/core/dom/ScriptedAnimationController.h (right): https://codereview.chromium.org/341433003/diff/1/Source/core/dom/ScriptedAnimationController.h#newcode43 Source/core/dom/ScriptedAnimationController.h:43: class ScriptedAnimationController : public RefCountedWillBeGarbageCollectedFinalized<ScriptedAnimationController> { On 2014/06/17 06:44:48, ...

6 years, 6 months ago (2014-06-17 06:50:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/341433003/1

6 years, 6 months ago (2014-06-17 07:19:20 UTC) #5

Message was sent while issue was closed.

Change committed as 176291

Expand Messages | Collapse Messages