Add lots of utils, PRESUBMIT.py

Add lots of utils, PRESUBMIT.py

BUG=skia:2682
R=jcgregorio@google.com, rmistry@google.com

Committed: https://skia.googlesource.com/common/+/c92e6d8

[borenet, 2014-06-20 16:39:04]

https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py
File py/utils/misc.py (right):

https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py#newcode17
py/utils/misc.py:17: os.pardir, os.pardir, os.pardir))
This should probably be removed, but there are things which depend on it.  Maybe
it should become CHECKOUT_ROOT or something?

[borenet, 2014-06-20 16:39:30]

Diff against patch set 1 to see what changed since the copy/paste. It's mainly
presubmit fixes.

[borenet, 2014-06-20 16:43:07]

+Joe

[rmistry, 2014-06-20 16:44:03]

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode17
PRESUBMIT.py:17: def _RunUnitTests(input_api, output_api):
_RunUnitTests -> _RunPyUnitTests

https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py
File py/utils/misc.py (right):

https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py#newcode17
py/utils/misc.py:17: os.pardir, os.pardir, os.pardir))
On 2014/06/20 16:39:04, borenet wrote:
> This should probably be removed, but there are things which depend on it. 
Maybe
> it should become CHECKOUT_ROOT or something?

SGTM

https://codereview.chromium.org/341193004/diff/60001/run_unittests
File run_unittests (right):

https://codereview.chromium.org/341193004/diff/60001/run_unittests#newcode1
run_unittests:1: #!/usr/bin/env python
This only runs python unit tests, it should probably be moved into py/

[tfarina, 2014-06-20 16:45:19]

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode41
PRESUBMIT.py:41:
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canne...
can you use the url from chromium.googlesource.com instead?

[jcgregorio, 2014-06-20 16:46:31]

On 2014/06/20 16:44:03, rmistry wrote:
> https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode17
> PRESUBMIT.py:17: def _RunUnitTests(input_api, output_api):
> _RunUnitTests -> _RunPyUnitTests
> 
> https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py
> File py/utils/misc.py (right):
> 
>
https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py#newcode17
> py/utils/misc.py:17: os.pardir, os.pardir, os.pardir))
> On 2014/06/20 16:39:04, borenet wrote:
> > This should probably be removed, but there are things which depend on it. 
> Maybe
> > it should become CHECKOUT_ROOT or something?
> 
> SGTM
> 
> https://codereview.chromium.org/341193004/diff/60001/run_unittests
> File run_unittests (right):
> 
> https://codereview.chromium.org/341193004/diff/60001/run_unittests#newcode1
> run_unittests:1: #!/usr/bin/env python
> This only runs python unit tests, it should probably be moved into py/

I think you also need an __init__.py in the directory above /py, but that
depends if PYTHONPATH is going to point to
$GITROOT/ or $GITROOT/common/.

[borenet, 2014-06-20 16:55:02]

Uploaded patch set 5, which addresses comments and adds an __init__.py at the
root level.

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode17
PRESUBMIT.py:17: def _RunUnitTests(input_api, output_api):
On 2014/06/20 16:44:03, rmistry wrote:
> _RunUnitTests -> _RunPyUnitTests

Done.

https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode41
PRESUBMIT.py:41:
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canne...
On 2014/06/20 16:45:19, tfarina wrote:
> can you use the url from http://chromium.googlesource.com instead?

Done.

https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py
File py/utils/misc.py (right):

https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py#newcode17
py/utils/misc.py:17: os.pardir, os.pardir, os.pardir))
On 2014/06/20 16:44:03, rmistry wrote:
> On 2014/06/20 16:39:04, borenet wrote:
> > This should probably be removed, but there are things which depend on it. 
> Maybe
> > it should become CHECKOUT_ROOT or something?
> 
> SGTM

If it's okay with you, I'll wait until we start depending on this copy of this
module before figuring out how it should work.

https://codereview.chromium.org/341193004/diff/60001/run_unittests
File run_unittests (right):

https://codereview.chromium.org/341193004/diff/60001/run_unittests#newcode1
run_unittests:1: #!/usr/bin/env python
On 2014/06/20 16:44:03, rmistry wrote:
> This only runs python unit tests, it should probably be moved into py/

Done.

[jcgregorio, 2014-06-20 16:55:45]

On 2014/06/20 16:55:02, borenet wrote:
> Uploaded patch set 5, which addresses comments and adds an __init__.py at the
> root level.
> 
> https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode17
> PRESUBMIT.py:17: def _RunUnitTests(input_api, output_api):
> On 2014/06/20 16:44:03, rmistry wrote:
> > _RunUnitTests -> _RunPyUnitTests
> 
> Done.
> 
> https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode41
> PRESUBMIT.py:41:
>
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canne...
> On 2014/06/20 16:45:19, tfarina wrote:
> > can you use the url from http://chromium.googlesource.com instead?
> 
> Done.
> 
> https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py
> File py/utils/misc.py (right):
> 
>
https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py#newcode17
> py/utils/misc.py:17: os.pardir, os.pardir, os.pardir))
> On 2014/06/20 16:44:03, rmistry wrote:
> > On 2014/06/20 16:39:04, borenet wrote:
> > > This should probably be removed, but there are things which depend on it. 
> > Maybe
> > > it should become CHECKOUT_ROOT or something?
> > 
> > SGTM
> 
> If it's okay with you, I'll wait until we start depending on this copy of this
> module before figuring out how it should work.
> 
> https://codereview.chromium.org/341193004/diff/60001/run_unittests
> File run_unittests (right):
> 
> https://codereview.chromium.org/341193004/diff/60001/run_unittests#newcode1
> run_unittests:1: #!/usr/bin/env python
> On 2014/06/20 16:44:03, rmistry wrote:
> > This only runs python unit tests, it should probably be moved into py/
> 
> Done.

lgtm

[rmistry, 2014-06-20 16:58:28]

LGTM

[borenet, 2014-06-20 17:06:03]

Committed patchset #5 manually as rc92e6d8 (presubmit successful).