Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 341193004: Add lots of utils, PRESUBMIT.py (Closed)

Created:
6 years, 6 months ago by borenet
Modified:
6 years, 6 months ago
Reviewers:
jcgregorio, rmistry
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

Patch Set 1 : Copy/pasted files from original locations #

Patch Set 2 : Fixes, remove modules which depend on chromium buildbot code #

Patch Set 3 : remove print #

Patch Set 4 : Remove another pritn #

Total comments: 9

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1145 lines, -0 lines) Patch
A .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A PRESUBMIT.py View 1 2 3 4 1 chunk +141 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A py/__init__.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A py/run_unittests View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
A py/utils/__init__.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A py/utils/android_utils.py View 1 chunk +321 lines, -0 lines 0 comments Download
A py/utils/git_utils.py View 1 chunk +46 lines, -0 lines 0 comments Download
A py/utils/misc.py View 1 chunk +138 lines, -0 lines 0 comments Download
A py/utils/shell_utils.py View 1 1 chunk +236 lines, -0 lines 0 comments Download
A py/utils/ssh_utils.py View 1 1 chunk +196 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
borenet
https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py File py/utils/misc.py (right): https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py#newcode17 py/utils/misc.py:17: os.pardir, os.pardir, os.pardir)) This should probably be removed, but ...
6 years, 6 months ago (2014-06-20 16:39:04 UTC) #1
borenet
Diff against patch set 1 to see what changed since the copy/paste. It's mainly presubmit ...
6 years, 6 months ago (2014-06-20 16:39:30 UTC) #2
borenet
+Joe
6 years, 6 months ago (2014-06-20 16:43:07 UTC) #3
rmistry
https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode17 PRESUBMIT.py:17: def _RunUnitTests(input_api, output_api): _RunUnitTests -> _RunPyUnitTests https://codereview.chromium.org/341193004/diff/60001/py/utils/misc.py File py/utils/misc.py ...
6 years, 6 months ago (2014-06-20 16:44:03 UTC) #4
tfarina
https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode41 PRESUBMIT.py:41: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py can you use the url from chromium.googlesource.com instead?
6 years, 6 months ago (2014-06-20 16:45:19 UTC) #5
jcgregorio
On 2014/06/20 16:44:03, rmistry wrote: > https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py > File PRESUBMIT.py (right): > > https://codereview.chromium.org/341193004/diff/60001/PRESUBMIT.py#newcode17 > ...
6 years, 6 months ago (2014-06-20 16:46:31 UTC) #6
borenet
Uploaded patch set 5, which addresses comments and adds an __init__.py at the root level. ...
6 years, 6 months ago (2014-06-20 16:55:02 UTC) #7
jcgregorio
On 2014/06/20 16:55:02, borenet wrote: > Uploaded patch set 5, which addresses comments and adds ...
6 years, 6 months ago (2014-06-20 16:55:45 UTC) #8
rmistry
LGTM
6 years, 6 months ago (2014-06-20 16:58:28 UTC) #9
borenet
6 years, 6 months ago (2014-06-20 17:06:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 manually as rc92e6d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698