Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 341143002: Port the json_results_generator code over from Blink. (Closed)

Created:
6 years, 6 months ago by Dirk Pranke
Modified:
6 years, 6 months ago
Reviewers:
bulach, ojan
CC:
bulach+watch_chromium.org, chromium-reviews, ilevy-cc_chromium.org, jbudorick, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Paweł Hajdan Jr., szager1
Project:
chromium
Visibility:
Public.

Description

Port the json_results_generator code over from Blink. The android tests use the python json_results_generator code from Blink in order to upload results to the flakiness dashboard. Previously they would import the code from Blink directly, creating a cross-repo dependency on files that weren't really meant to be public. In addition, eventually Blink stopped needing the JSONResultsGenerator classes altogether, so the android scripts were the *only* users. This patch moves the file over and strips the remaining webkitpy dependencies. This patch also changes the license block to match the Chromium license. I traced the commit history of these files; there were only ever two commits by non-Googlers: one was a trivial variable rename by rniwa after he had left Google, and the other was a change by zandobersek which was removed as part of me stripping the webkitpy dependencies, so I think this is safe. R=ojan@chromium.org BUG=242206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279515

Patch Set 1 : copy the original files over from blink #

Patch Set 2 : remove webkitpy dependencies #

Total comments: 1

Patch Set 3 : convert to Chromium Python style, lint #

Patch Set 4 : more linting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -36 lines) Patch
M build/android/pylib/utils/flakiness_dashboard_results_uploader.py View 1 2 3 4 chunks +7 lines, -36 lines 0 comments Download
A build/android/pylib/utils/json_results_generator.py View 1 2 3 1 chunk +697 lines, -0 lines 0 comments Download
A build/android/pylib/utils/json_results_generator_unittest.py View 1 2 3 1 chunk +213 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Dirk Pranke
Take a look. This is the meat of the change. Assuming this looks good, I'll ...
6 years, 6 months ago (2014-06-20 01:13:42 UTC) #1
bulach
cc jbudorick, he was investigating json-ifying and structuring the test results, there maybe some overlap. ...
6 years, 6 months ago (2014-06-20 01:27:29 UTC) #2
ojan
LGTM. This is a step in the right direction. This should really be changed to ...
6 years, 6 months ago (2014-06-20 01:36:54 UTC) #3
Dirk Pranke
On 2014/06/20 01:27:29, bulach wrote: > cc jbudorick, he was investigating json-ifying and structuring the ...
6 years, 6 months ago (2014-06-20 01:37:30 UTC) #4
Dirk Pranke
On 2014/06/20 01:36:54, OOO-only-code-yellow-reviews wrote: > LGTM. This is a step in the right direction. ...
6 years, 6 months ago (2014-06-20 01:38:10 UTC) #5
Dirk Pranke
On 2014/06/20 01:38:10, Dirk Pranke wrote: Marcus, can you give me OWNERS approval?
6 years, 6 months ago (2014-06-20 01:38:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/341143002/60001
6 years, 6 months ago (2014-06-20 01:40:15 UTC) #7
bulach
lgtm for owners, thanks for breaking this dependency! https://codereview.chromium.org/341143002/diff/60001/build/android/pylib/utils/json_results_generator.py File build/android/pylib/utils/json_results_generator.py (right): https://codereview.chromium.org/341143002/diff/60001/build/android/pylib/utils/json_results_generator.py#newcode25 build/android/pylib/utils/json_results_generator.py:25: # ...
6 years, 6 months ago (2014-06-20 01:42:37 UTC) #8
ojan
On 2014/06/20 at 01:38:10, dpranke wrote: > On 2014/06/20 01:36:54, OOO-only-code-yellow-reviews wrote: > > LGTM. ...
6 years, 6 months ago (2014-06-20 01:43:38 UTC) #9
Dirk Pranke
The CQ bit was unchecked by dpranke@chromium.org
6 years, 6 months ago (2014-06-20 01:44:40 UTC) #10
Dirk Pranke
On 2014/06/20 01:42:37, bulach wrote: > not sure how much should we care about chromi-fy ...
6 years, 6 months ago (2014-06-20 01:45:17 UTC) #11
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-20 20:21:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/341143002/80001
6 years, 6 months ago (2014-06-20 20:23:40 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-21 03:04:03 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 03:07:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75360)
6 years, 6 months ago (2014-06-21 03:07:42 UTC) #16
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-24 19:02:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/341143002/100001
6 years, 6 months ago (2014-06-24 19:04:24 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 22:15:14 UTC) #19
Message was sent while issue was closed.
Change committed as 279515

Powered by Google App Engine
This is Rietveld 408576698