Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc

Issue 341123005: Disable getMediaDevices tests. Revert to use getSources instead for getUserMedia tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webrtc/media_devices.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc b/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc
index f7e79873e3ad81456be4ae6f1ef4a402b19001b0..2c9164becab7ab2e49918b74fa808a3a0234b437 100644
--- a/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc
@@ -181,8 +181,10 @@ INSTANTIATE_TEST_CASE_P(WebRtcGetMediaDevicesBrowserTests,
WebRtcGetMediaDevicesBrowserTest,
testing::ValuesIn(kParamsToRunTestsWith));
+// getMediaDevices is removed and will be replaced
tommi (sloooow) - chröme 2014/07/03 09:43:04 nit: s/is/has been
Henrik Grunell 2014/07/03 10:44:48 Done.
+// MediaDevices.enumerateDevices. http://crbug.com/388648.
IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
- GetMediaDevicesWithoutAccess) {
+ DISABLED_GetMediaDevicesWithoutAccess) {
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
GURL url(embedded_test_server()->GetURL(kMainWebrtcTestHtmlPage));
ui_test_utils::NavigateToURL(browser(), url);
@@ -199,6 +201,8 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
}
}
+// getMediaDevices is removed and will be replaced
tommi (sloooow) - chröme 2014/07/03 09:43:04 has been
Henrik Grunell 2014/07/03 10:44:48 Done here and below.
+// MediaDevices.enumerateDevices. http://crbug.com/388648.
// Disabled, fails due to http://crbug.com/382391.
IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
DISABLED_GetMediaDevicesWithAccess) {
@@ -220,8 +224,10 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
}
}
+// getMediaDevices is removed and will be replaced
+// MediaDevices.enumerateDevices. http://crbug.com/388648.
IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
- GetMediaDevicesEqualsGetSourcesWithoutAccess) {
+ DISABLED_GetMediaDevicesEqualsGetSourcesWithoutAccess) {
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
GURL url(embedded_test_server()->GetURL(kMainWebrtcTestHtmlPage));
ui_test_utils::NavigateToURL(browser(), url);
@@ -252,6 +258,8 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
EXPECT_EQ(sources.end(), sources_it);
}
+// getMediaDevices is removed and will be replaced
+// MediaDevices.enumerateDevices. http://crbug.com/388648.
// Disabled, fails due to http://crbug.com/382391.
IN_PROC_BROWSER_TEST_P(WebRtcGetMediaDevicesBrowserTest,
DISABLED_GetMediaDevicesEqualsGetSourcesWithAccess) {
« no previous file with comments | « no previous file | chrome/test/data/webrtc/media_devices.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698