Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 341043008: Add FileSystemID parameter to IsolatedContext::RegisterFileSystemForPath. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tzik, nasko+codewatch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, vsevik, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, creis+watch_chromium.org, nhiroki, paulirish+reviews_chromium.org, oshima+watch_chromium.org, Lei Zhang, tfarina, yurys, tommycli, davemoore+watch_chromium.org, Greg Billock, kinuko+fileapi, pfeldman
Project:
chromium
Visibility:
Public.

Description

Add FileSystemID parameter to IsolatedContext::RegisterFileSystemForPath. With this change, nested filesystems mounted onto isolated context can remember its original filesystem id, that unblocks the issue 370782 of drag-and-drop support in chromeos::FileSystemBackend. BUG=370782, 386062 TBR=kaznacheev, benwells, dmichael, sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -41 lines) Patch
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/external_mount_points_unittest.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M content/browser/fileapi/isolated_context_unittest.cc View 7 chunks +21 lines, -13 lines 0 comments Download
M content/browser/fileapi/transient_file_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/external_mount_points.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/fileapi/external_mount_points.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/isolated_context.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_context.cc View 10 chunks +24 lines, -8 lines 0 comments Download
M webkit/browser/fileapi/mount_points.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kinaba
6 years, 6 months ago (2014-06-20 03:13:56 UTC) #1
tzik
lgtm
6 years, 6 months ago (2014-06-20 03:30:30 UTC) #2
kinaba
On 2014/06/20 03:30:30, tzik wrote: > lgtm Added TBR for changes affected by the added ...
6 years, 6 months ago (2014-06-20 03:40:02 UTC) #3
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-20 03:40:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/341043008/1
6 years, 6 months ago (2014-06-20 03:44:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 09:05:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 09:31:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/164529)
6 years, 6 months ago (2014-06-20 09:31:44 UTC) #8
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-20 09:32:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/341043008/1
6 years, 6 months ago (2014-06-20 09:34:56 UTC) #10
commit-bot: I haz the power
Change committed as 278666
6 years, 6 months ago (2014-06-20 10:40:19 UTC) #11
dmichael (off chromium)
6 years, 6 months ago (2014-06-20 14:54:54 UTC) #12
Message was sent while issue was closed.
pepper lgtm

Powered by Google App Engine
This is Rietveld 408576698