chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc - Issue 341043008: Add FileSystemID parameter to IsolatedContext::RegisterFileSystemForPath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc

Issue 341043008: Add FileSystemID parameter to IsolatedContext::RegisterFileSystemForPath. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_file_helper.cc ('k') | chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc

diff --git a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc b/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc

index 277bc9908dceab83e1044b2deaff22a3e6257b39..91b24c56cebf03b40d743e6c48a362539fdfd5d8 100644

--- a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc

+++ b/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc

@@ -299,7 +299,7 @@ GrantedFileEntry CreateFileEntry(

DCHECK(isolated_context);

result.filesystem_id = isolated_context->RegisterFileSystemForPath(

- fileapi::kFileSystemTypeNativeForPlatformApp, path,

+ fileapi::kFileSystemTypeNativeForPlatformApp, std::string(), path,

&result.registered_name);

content::ChildProcessSecurityPolicy* policy =

@@ -368,8 +368,10 @@ bool ValidateFileEntryAndGetPath(

.Append(relative_path);

fileapi::FileSystemType type;

fileapi::FileSystemMountOption mount_option;

+ std::string cracked_id;

if (!context->CrackVirtualPath(

- virtual_path, &filesystem_id, &type, file_path, &mount_option)) {

+ virtual_path, &filesystem_id, &type, &cracked_id, file_path,

+ &mount_option)) {

*error = kInvalidParameters;

return false;

}