Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: content/browser/loader/buffered_resource_handler.cc

Issue 340953006: Fix some DCHECKS when using BrowserPlugin for extension mime type handlers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/buffered_resource_handler.cc
diff --git a/content/browser/loader/buffered_resource_handler.cc b/content/browser/loader/buffered_resource_handler.cc
index f609cbfbef752167b0ad743768d482eff9ac9c65..8fb8c5d4484c1d4ef473ed551a3dfe5613598ec7 100644
--- a/content/browser/loader/buffered_resource_handler.cc
+++ b/content/browser/loader/buffered_resource_handler.cc
@@ -386,7 +386,7 @@ bool BufferedResourceHandler::UseAlternateNextHandler(
scoped_refptr<net::IOBuffer> buf;
int size = 0;
- next_handler_->OnWillRead(&buf, &size, payload_for_old_handler.length());
+ next_handler_->OnWillRead(&buf, &size, -1);
mmenke 2014/06/19 15:08:42 Why this change?
Zachary Kuznia 2014/06/19 18:02:24 This always ends up forwarding to AsyncResourceHan
mmenke 2014/06/19 19:36:26 Ahh...right. Ugly, but we're really bad about how
CHECK_GE(size, static_cast<int>(payload_for_old_handler.length()));
memcpy(buf->data(), payload_for_old_handler.c_str(),
« chrome/browser/extensions/plugin_manager.cc ('K') | « chrome/browser/extensions/plugin_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698