Fix some DCHECKS when using BrowserPlugin for extension mime type handlers

content/browser/loader/buffered_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/buffered_resource_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 368 matching lines @@
   DCHECK(!defer_ignored);
   if (payload_for_old_handler.empty()) {
     net::URLRequestStatus status(net::URLRequestStatus::CANCELED,
                                  net::ERR_ABORTED);
     next_handler_->OnResponseCompleted(status, std::string(), &defer_ignored);
     DCHECK(!defer_ignored);
   } else {
     scoped_refptr<net::IOBuffer> buf;
     int size = 0;
 
-    next_handler_->OnWillRead(&buf, &size, payload_for_old_handler.length());
+    next_handler_->OnWillRead(&buf, &size, -1);

[mmenke, 2014/06/19 15:08:42]

Why this change?

[Zachary Kuznia, 2014/06/19 18:02:24]

This always ends up forwarding to AsyncResourceHandler::OnWillRead(), which does
a DCHECK_EQ(-1, min_size);

[mmenke, 2014/06/19 19:36:26]

Ahh...right.  Ugly, but we're really bad about how that works, as-is.  Since we
have a CHECK just below, this is fine.  We really should figure out a better way
to do all this, but that ball's not in your court.

     CHECK_GE(size, static_cast<int>(payload_for_old_handler.length()));
 
     memcpy(buf->data(), payload_for_old_handler.c_str(),
            payload_for_old_handler.length());
 
     next_handler_->OnReadCompleted(payload_for_old_handler.length(),
                                    &defer_ignored);
     DCHECK(!defer_ignored);
 
     net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
@@ skipping 91 matching lines @@
   request()->LogUnblocked();
   bool defer = false;
   if (!ProcessResponse(&defer)) {
     controller()->Cancel();
   } else if (!defer) {
     controller()->Resume();
   }
 }
 
 }  // namespace content