Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 340893002: Allow gpu debug markers to be placed by using a GrContext (Closed)

Created:
6 years, 6 months ago by egdaniel
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Allow gpu debug markers to be placed by using a GrContext If a marker is placed using a GrContext, it will add a marker to both the drawBuffer and gpu targets of that context. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bbcb38df4f7477aa0a38da00a0757586a0125954

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add add/remove marker to GrContext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M include/gpu/GrContext.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/GrTracing.h View 1 4 chunks +44 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
egdaniel
ptal
6 years, 6 months ago (2014-06-18 20:31:54 UTC) #1
bsalomon
https://codereview.chromium.org/340893002/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/340893002/diff/1/include/gpu/GrContext.h#newcode914 include/gpu/GrContext.h:914: GrInOrderDrawBuffer* getDrawBuffer() { return fDrawBuffer; } Ahhhhhhhhh https://codereview.chromium.org/340893002/diff/1/src/gpu/GrTracing.h File ...
6 years, 6 months ago (2014-06-18 20:35:17 UTC) #2
egdaniel
Add and remove marker functions added to GrContext so we don't expose the drawBuffer https://codereview.chromium.org/340893002/diff/1/include/gpu/GrContext.h ...
6 years, 6 months ago (2014-06-18 21:03:43 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/340893002/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/340893002/diff/1/include/gpu/GrContext.h#newcode914 include/gpu/GrContext.h:914: GrInOrderDrawBuffer* getDrawBuffer() { return fDrawBuffer; } On 2014/06/18 ...
6 years, 6 months ago (2014-06-18 21:14:47 UTC) #4
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-19 13:17:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/340893002/60001
6 years, 6 months ago (2014-06-19 13:17:57 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 17:19:34 UTC) #7
Message was sent while issue was closed.
Change committed as bbcb38df4f7477aa0a38da00a0757586a0125954

Powered by Google App Engine
This is Rietveld 408576698