sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 340783011: Take inheritance into account when computing the elements accessible by mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 340783011: Take inheritance into account when computing the elements accessible by mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('j') | sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index 3e269a2692823c990cd7e0ff1643165234f170cd..bf5026229585797100c964aceff51d9f9b011f1d 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -661,7 +661,8 @@ class CodeEmitterTask extends CompilerTask {

elementOrSelector is Element &&

// Make sure to retain names of unnamed constructors, and

// for common native types.

- (name == '' && backend.isNeededForReflection(elementOrSelector) ||

+ (name == '' &&

Johnni Winther 2014/06/27 07:43:01 Add parentheses around 'name == ... isAccess...(..

herhut 2014/06/27 12:34:38 Done.

+ backend.isAccessibleByReflection(elementOrSelector) ||

_isNativeTypeNeedingReflectionName(elementOrSelector))) {

// TODO(ahe): Enable the next line when I can tell the difference between