Chromium Code Reviews| Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart |
| diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart |
| index 1a05988ec2e47106d037488737cd566ccf6620c7..34d7735b2ae048f3bca8ccb90053de3cc45d9409 100644 |
| --- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart |
| +++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart |
| @@ -224,11 +224,8 @@ class ClassEmitter extends CodeEmitterHelper { |
| } |
| } |
| if (backend.isAccessibleByReflection(field)) { |
| - reflectionMarker = '-'; |
|
karlklose
2014/06/27 07:45:57
Why is the marker not needed anymore?
herhut
2014/06/27 12:34:37
Not clear what this did before but the differentia
|
| - if (backend.isNeededForReflection(field)) { |
| - DartType type = field.type; |
| - reflectionMarker = '-${task.metadataEmitter.reifyType(type)}'; |
| - } |
| + DartType type = field.type; |
| + reflectionMarker = '-${task.metadataEmitter.reifyType(type)}'; |
| } |
| builder.addField('$fieldName$fieldCode$reflectionMarker'); |
| fieldsAdded = true; |
| @@ -313,7 +310,7 @@ class ClassEmitter extends CodeEmitterHelper { |
| classBuilder.addProperty("@", metadata); |
| } |
| - if (backend.isNeededForReflection(classElement)) { |
| + if (backend.isAccessibleByReflection(classElement)) { |
| Link typeVars = classElement.typeVariables; |
| Iterable typeVariableProperties = task.typeVariableHandler |
| .typeVariablesOf(classElement).map(js.number); |
| @@ -353,7 +350,7 @@ class ClassEmitter extends CodeEmitterHelper { |
| String reflectionName = task.getReflectionName(classElement, className); |
| if (reflectionName != null) { |
| - if (!backend.isNeededForReflection(classElement)) { |
| + if (!backend.isAccessibleByReflection(classElement)) { |
| enclosingBuilder.addProperty("+$reflectionName", js.number(0)); |
| } else { |
| List<int> types = <int>[]; |
| @@ -536,7 +533,7 @@ class ClassEmitter extends CodeEmitterHelper { |
| task.precompiledFunction.add( |
| js('#.prototype.# = function(#) { return #.# }', |
| [className, getterName, args, receiver, fieldName])); |
| - if (backend.isNeededForReflection(member)) { |
| + if (backend.isAccessibleByReflection(member)) { |
| task.precompiledFunction.add( |
| js('#.prototype.#.${namer.reflectableField} = 1', |
| [className, getterName])); |
| @@ -554,7 +551,7 @@ class ClassEmitter extends CodeEmitterHelper { |
| // TODO: remove 'return'? |
| js('#.prototype.# = function(#, v) { return #.# = v; }', |
| [className, setterName, args, receiver, fieldName])); |
| - if (backend.isNeededForReflection(member)) { |
| + if (backend.isAccessibleByReflection(member)) { |
| task.precompiledFunction.add( |
| js('#.prototype.#.${namer.reflectableField} = 1', |
| [className, setterName])); |