Source/core/editing/VisibleSelection.cpp - Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleSelection.cpp

Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/execCommand/delete-hidden-crash.html ('K') | « Source/core/editing/VisiblePosition.cpp ('k') | Source/core/editing/htmlediting.h » ('j') | Source/core/editing/htmlediting.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/VisibleSelection.cpp

diff --git a/Source/core/editing/VisibleSelection.cpp b/Source/core/editing/VisibleSelection.cpp

index 753da69b7a295ef9f428906cba7d331ca9ab5aee..b4dbeba93a200f8c3dc37cafe295d16275afe1e2 100644

--- a/Source/core/editing/VisibleSelection.cpp

+++ b/Source/core/editing/VisibleSelection.cpp

@@ -615,7 +615,7 @@ void VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries()

// If the end is in non-editable content that is inside the base's root, put it

// at the last editable position before the end inside the base's root.

if (endRoot != baseRoot) {

- VisiblePosition last = lastEditablePositionBeforePositionInRoot(m_end, baseRoot);

+ VisiblePosition last = VisiblePosition(lastEditablePositionBeforePositionInRoot(m_end, baseRoot));

m_end = last.deepEquivalent();

if (m_end.isNull())

m_end = m_start;